[OpenSIPS-Users] add_path_received not behaving (2.4)

[Bogdan-Andrei Iancu]

OK, the issue was introduced with this commit:
https://github.com/OpenSIPS/opensips/commit/045eea09bfb294f5a615d508bd3fc70317389563#diff-077e335c49f591dee316bb34fbddcd98

This commit moved the "received" param to the second Path header (when 
doing interface switching), but this second hdr is optional, it is added 
only if different (as interface) from the first one.
So, if you have a single Path hdr to be added, the "received" will be 
missed, as it is added to a hdr what will be discarded at the end (not 
included in the SIP message).

Regards,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   https://www.opensips-solutions.com
OpenSIPS Summit 2019
   https://www.opensips.org/events/Summit-2019Amsterdam/

On 08/13/2019 12:54 PM, Bogdan-Andrei Iancu wrote:
> And in your case, it is a double Path scenario, or you get only one 
> added ?
>
> Regards,
> Bogdan-Andrei Iancu
>
> OpenSIPS Founder and Developer
>    https://www.opensips-solutions.com
> OpenSIPS Summit 2019
>    https://www.opensips.org/events/Summit-2019Amsterdam/
> On 08/13/2019 11:17 AM, Pete Kelly wrote:
>> Hi Bogdan
>>
>> It's set to 1 (as is use_received)
>>
>> Pete
>>
>> On Tue, 13 Aug 2019 at 07:53, Bogdan-Andrei Iancu 
>> <bogdan at opensips.org <mailto:bogdan at opensips.org>> wrote:
>>
>>     Hi Pete,
>>
>>     What is the setting for the `enable_double_path` modparam ?
>>
>>     Regards,
>>
>>     Bogdan-Andrei Iancu
>>
>>     OpenSIPS Founder and Developer
>>        https://www.opensips-solutions.com
>>     OpenSIPS Summit 2019
>>        https://www.opensips.org/events/Summit-2019Amsterdam/
>>
>>     On 08/12/2019 04:34 PM, Pete Kelly wrote:
>>>     Hello!
>>>
>>>     I am using add_path_received() when "proxying" REGISTERs through
>>>     an edge proxy, and have been successfully using it with earlier
>>>     versions of OpenSIPS (1.x, 2.1, 2.2, 2.3) with the same script.
>>>
>>>     However I have noticed that since at least 2.4.5 it does not
>>>     seem to be behaving, the add_path_received() function is *not*
>>>     adding the received param - it's behaving exactly as add_path()
>>>     would behave.
>>>
>>>     I've tried checking the return code and also increasing
>>>     debugging, but there is no output to suggest that the function
>>>     call itself is failing.
>>>
>>>     I also noticed this ticket, but it shouldn't affect 2.4
>>>     https://github.com/OpenSIPS/opensips/issues/1739
>>>
>>>
>>>     Are there any suggestions?
>>>
>>>     Pete
>>>
>>>
>>>     _______________________________________________
>>>     Users mailing list
>>>     Users at lists.opensips.org <mailto:Users at lists.opensips.org>
>>>     http://lists.opensips.org/cgi-bin/mailman/listinfo/users
>>
>
>
>
> _______________________________________________
> Users mailing list
> Users at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/users

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/users/attachments/20190813/0685a005/attachment.html>