[OpenSIPS-Users] CANCEL & INVITE

[Bogdan-Andrei Iancu]

Some update here, to keep the list also informed.

I re-checked the code and I found some regression in CANCEL handling - 
this was added last year with commit 
4747da559f4df161441be8373488dee9fd16c282 when support for 
"Content-Disposition: no-cancel" was added.
https://github.com/OpenSIPS/opensips/commit/4747da559f4df161441be8373488dee9fd16c282

Also I just pushed a fix (on master) for this issue
https://github.com/OpenSIPS/opensips/commit/f1a6d0d8e46c4aff9f203f2eb7e85a2b1e40cf92

Richard, would you please test it also and confirm the fix, so I can do 
safe backport to 3.0 and 2.4 ?

Many thanks,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   https://www.opensips-solutions.com
OpenSIPS Summit 2019
   https://www.opensips.org/events/Summit-2019Amsterdam/

On 06/21/2019 06:26 PM, Bogdan-Andrei Iancu wrote:
> Woooow - we have a record here :) - resuming a discussion over 8 years 
> !!!!!
>
> AFAIK, there was no intentional change (when comes to canceling 
> branches with no reply) - do you have a pcap + logs to show such 
> behavior ?
>
> And in regards to the sequence of CANCEL (on timeout) + forking, I 
> think this was fixed starting 1.7 - first the CANCEL is sent out and 
> then the new potential branches.
>
> Regards,
> Bogdan-Andrei Iancu
>
> OpenSIPS Founder and Developer
>    https://www.opensips-solutions.com
> OpenSIPS Summit 2019
>    https://www.opensips.org/events/Summit-2019Amsterdam/
> On 06/20/2019 01:06 AM, Richard Revels wrote:
>> I'm going to resurrect this as I've noticed that opensips 2.4.6 sends 
>> CANCEL for branches it never got a provisional response for.  Was 
>> this changed intentionally?
>>
>> Also, it looks like the discussion I am responding on was about 
>> opensips 1.5 but if any testing is needed around fail-over scenarios 
>> I expect to be doing some of that over the next few days.  Just let 
>> me know what still needs to be looked at and I'll try to get it in.
>>
>>
>> BandwidthMaroon.png
>>
>> 	
>>
>> Richard Revels•System Architect II
>>
>> 900 Main Campus Drive, Suite 100, Raleigh, NC 27606
>>
>> m:919-578-3421 • o: 919-727-4614
>>
>> e: rrevels at bandwidth.com <mailto:rrevels at bandwidth.com>
>>
>>
>>
>> On Tue, Apr 5, 2011 at 3:33 PM Bogdan-Andrei Iancu 
>> <bogdan at opensips.org <mailto:bogdan at opensips.org>> wrote:
>>
>>     Hi guys,
>>
>>     Actually it will be great to have that patch tested to know for
>>     sure if
>>     the problem is solved. I never got a 100% confirmation from
>>     Andrew, but
>>     maybe Piotr can test and confirm.
>>
>>     Thanks and regards,
>>     Bogdan
>>
>>     On 04/05/2011 04:58 PM, Andrew Pogrebennyk wrote:
>>     > Hi Piotr,
>>     > This sounds familiar to the problem I experienced some time ago
>>     - make
>>     > sure to check comments here:
>>     >
>>     https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2940556&group_id=232389
>>     >
>>     > I haven't been able to replicate that setup to confirm that the
>>     > attached patch works. You are welcome to try it though :) Note RFC
>>     > states it clearly that if no response has been received from
>>     the UAS
>>     > at all, we should not attempt to send a CANCEL there.
>>     >
>>     > But it seems that in your case you received some provisional
>>     response
>>     > so the issue has to do with the order in which CANCEL is fired -
>>     > exactly what the patch is intended to fix.
>>     >
>>     > On 05.04.2011 15:56, Piotr Sobolewski wrote:
>>     >> I'm having problem with specific gateway to which OpenSIPS sends
>>     >> INVITE and then another INVITE (CallForward on no Aswer).
>>     >> The  problem is when after sending first INVITE to gateway
>>     (without
>>     >> getting final response), OpenSIPS hits failure route and then
>>     sends
>>     >> another INVITE (with different RURI) toward gateway before
>>     CANCEL is
>>     >> sent, so the gateway responds to second INVITE with "482 Request
>>     >> merged" (and gateway does not attempt to make second connection).
>>     >> Is there a way to send CANCEL before sending second INVITE ?
>>     >
>>
>>
>>     -- 
>>     Bogdan-Andrei Iancu
>>     OpenSIPS eBootcamp - 2nd of May 2011
>>     OpenSIPS solutions and "know-how"
>>
>>
>>     _______________________________________________
>>     Users mailing list
>>     Users at lists.opensips.org <mailto:Users at lists.opensips.org>
>>     http://lists.opensips.org/cgi-bin/mailman/listinfo/users
>>
>>
>>
>> _______________________________________________
>> Users mailing list
>> Users at lists.opensips.org
>> http://lists.opensips.org/cgi-bin/mailman/listinfo/users
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/users/attachments/20190807/4e758046/attachment-0001.html>