[OpenSER-Devel] SF.net SVN: openser: [3483] trunk

[Henning Westerholt]

On Sunday 23 December 2007, Juha Heinanen wrote:
> Revision: 3483
>           http://openser.svn.sourceforge.net/openser/?rev=3483&view=rev
> Author:   juhe
> Date:     2007-12-23 03:22:25 -0800 (Sun, 23 Dec 2007)
>
> Log Message:
> -----------
> * Introduced pvar_fixup and free_pvar_fixup mod_fix functions and used
>   them in lcr, domain, and uri modules.

Hi Juha,

i wanted to change carrierroute to use the fixup functions introduced by you. 
I noticed that you use the pv_parse_spec in the fixup function you've 
created, but carrierroute (and some other modules) uses pv_parse_format. 
I reviewed the code in pvar.c, and notices that pv_parse_format calls pv_parse 
spec internally, but does some more stuff.

Its safe to use the pv_parse_spec function instead of the pv_parse_format? Or 
perhaps better use the pv_parse_format in the fixup function too?
What is the suggested way of fixing PVs?

Best regards,

Henning