2008-12-08 20:45:12 Bogdan-Andrei Iancu, * [5050] : backport from trunk (rev #5049): - first attempt in fixing ugly bug in concurent access to the request sip_msg structured cloned in SHM memory (in transaction) - callbacks are not sync'ed, so fo the same transaction, more than one callback can be run at a given moment -> write access to the shared request is not safe at all Current TM callback status: ### acesing shm req with parsing of req #define TMCB_RESPONSE_OUT (1<<7) req = T_uas (parsed by acc) #define TMCB_ON_FAILURE_RO (1<<5) req = T_uas (parsed) #define TMCB_ON_FAILURE (1<<6) req = T_uas (parsed) #### accessing shm req, but not parsing it #define TMCB_RESPONSE_IN (1<<1) req = T_uas #define TMCB_RESPONSE_FWDED (1<<4) req = T_uas #### no access to shm msg #define TMCB_REQUEST_BUILT (1<<10) req = p_msg #define TMCB_REQUEST_FWDED (1<<3) req = p_msg #define TMCB_E2EACK_IN (1<<2) req = ACK #define TMCB_REQUEST_IN (1<<0) req = p_msg #define TMCB_TRANS_DELETED (1<<11) req = null #define TMCB_LOCAL_COMPLETED (1<<8) req = null #define TMCB_LOCAL_RESPONSE_OUT (1<<9) req = null -> callbacks with no parsing access must not try to free eventual adds-on (because of parsing), because it may "see" parsed structs added by a concurent callback. -> also a race may occure between TMCB_RESPONSE_OUT and TMCB_ON_FAILURE callbacks (rw access to the same structure) This is not a final fix but an intermediary one (at least reduces the chances of a crash with 99%). Future final fix will be: 1) do not allow extra parsing of cloned requests 2) allow parsing of cloned requests, but make local copies before parsing 2008-12-08 14:03:55 Anca Vamanu, * [5048] : - fixed '0' return code from bla_handle_notify function in pua_bla modules that caused exiting from the script ( reported by Norm Brandinger, closes bug #2225405, applied modified patch from Sergio Gutierrez , patch #2352405) 2008-12-08 13:42:15 Anca Vamanu, * [5046] : - fixed including initial rute set in subsequent Notify requests ( reported by Nathan, closes bug #2391787 ) 2008-12-08 12:56:30 Anca Vamanu, * [5044] : - fixed auid for presence rules document ( reported by Kenneth Löfstrand ) 2008-12-04 17:02:40 Anca Vamanu, * [5042] : - backport from trunk (rev 5041) - fixed an error in nonce generation( using wrong macro) - adjust default nonce_expires to 30 seconds 2008-12-04 11:45:51 Anca Vamanu, * [5039] : - backport from trunk ( rev 5038) - fixed bug in rls when adding contact header in 200ok replies to SUBSCRIBE messages (closes bug #2354984, opened by Nathan ) - fixed omission in documentation -setting server_address parameter - fixed adding protocol in Contact header if protocol different than udp for Notify requests in presence modules and Subscribe replies and Notify requests in rls module ( reported by Inaki Baz) 2008-11-28 13:15:14 Dan Pascu * [5036] : Call dialog create callbacks after the dialog identity is established 2008-11-28 13:07:03 Dan Pascu * [5034] : Fixed segmentation fault caused by the wrong use of realloc instead of pkg_realloc 2008-11-26 17:13:42 Bogdan-Andrei Iancu, * [5033] : - backport from trunk (rev #5030 - #5032): - add "transport=proto" paramter to the contact if other proto than UDP is used. Closes bug 2335193. Reported by Inaki Baz. 2008-11-24 17:43:47 Dan Pascu * [5027] : Set proper status in accounting when called during request processing 2008-11-24 16:16:26 Dan Pascu * [5025] : Fixed compiler warnings about pointer typecasts 2008-11-24 15:52:14 Dan Pascu * [5024] : Avoid gcc 4.3.2+ warning 2008-11-23 17:45:17 Sergio Gutierrez * [5017] : - Replaced strncmp by strncasecmp in comparing SIP/SDP headers. Fixes bug #2204065 2008-11-21 18:42:43 Anca Vamanu, * [5015] : -fixed bug in pua that caused segmentation fault when publish was sent with pua_mi and records were lost from presentity table ( reported by Mika Saari) 2008-11-21 17:54:12 Bogdan-Andrei Iancu, * [5013] : backport from trunk (rev #5012): - fixed bogus usage of index [-1] in array - when acc is triggered by a local reply, there is no outgoing branch -> bogus memory access 2008-11-21 17:47:41 Dan Pascu * [5011] : Avoid a double free introduced by a previous fix 2008-11-21 17:44:49 Dan Pascu * [5009] : Do not bother unreferencing dialogs during shutdown, because the dialog and the dialog table is already gone 2008-11-21 17:42:09 Dan Pascu * [5007] : Free dialog callback params during shutdown 2008-11-21 17:16:00 Anca Vamanu, * [5005] : - fixed adding 2 Max-Forwards headers ( closes bug item #2320504) 2008-11-21 13:27:59 Dan Pascu * [5002] : Avoid invalid memory access of already released nat_table during shutdown 2008-11-21 12:23:49 Bogdan-Andrei Iancu, * [5000] : backport from trunk (rev #4999): - fixed memory leak related to local route. Credits go to Dan Pascu 2008-11-21 03:28:02 Di-Shi Sun * [4996] : Updated doc. 2008-11-20 23:47:15 Dan Pascu * [4995] : Fixed dialog unreferencing in case the transaction is not created 2008-11-20 20:57:08 Dan Pascu * [4993] : Added infrastructure for tm callback parameter cleanup. Fixed memory corruption caused by invalid freeing of dialogs 2008-11-20 19:08:05 Dan Pascu * [4988] : Test if memory was actually allocated and return error if not 2008-11-20 19:05:52 Dan Pascu * [4987] : Removed code with no effect 2008-11-20 19:01:37 Dan Pascu * [4986] : Fixed memory leak in db code 2008-11-20 09:13:38 Dan Pascu * [4979] : Avoid potential read overflow on non NULL terminated string 2008-11-20 09:10:21 Dan Pascu * [4978] : Do not use C++ style of defining variables in the middle of the code 2008-11-19 17:06:27 Ovidiu Sas * [4975] : adding error logs for dlg timer removal 2008-11-19 00:06:51 Ovidiu Sas * [4972] : turn dialog timeout debug probes into warning probes 2008-11-18 21:08:12 Ovidiu Sas * [4970] : log bogus negative dialog refs 2008-11-18 19:48:48 Ovidiu Sas * [4968] : adding error logs for failed dialog insertions into the timer list 2008-11-18 18:45:54 Ovidiu Sas * [4967] : backport from trunk (r4966) - enhance next_state_dlg error probes 2008-11-18 14:17:37 Bogdan-Andrei Iancu, * [4965] : backport from trunk (rev #4964): - fixed bug in acc_logic while accouitng the early media replies - the Content-len header may not be present! Many thanks to Jeff Pyle for help and support in debugging this. 2008-11-14 18:59:28 Sergio Gutierrez * [4949] : Backport from Kamailio, rev 5187. Credits to Henning Westerholt. Fixes bug of missed return statement when use_table fails. 2008-11-14 04:52:06 Di-Shi Sun * [4946] : Fixed reporting wrong destination count issue. 2008-11-13 17:34:45 Anca Vamanu, * [4945] : - backport from trunk rev 4944 - made code return and SIP reply sending more consistent for functions exported by presence and rls modules: - returns: 1- success -1- error - always sends a SIP reply either 2xx(success) or an appropriate error code (reported by Dan Pascu ) - for the scope above- changed the interface for xcapGetNewDoc function exported by xcap_client module to return a more appropriate result of the processing; updated presence_xml to the new interface - changed Subscribe handling policy in RLS: if Supported: eventlist header found and no list definition for service uri in xcap documents found - send 404 Not Found instead of forwarding the message to presence server -(reported by Dan Pascu ) - fixed library dependencies in doc to devel version ( libxml-dev instead of libxml) 2008-11-11 15:39:16 Sergio Gutierrez * [4941] : Corrected error in transcription of modparams. Fixes bug 2262249. Thanks to Sebastian Schuman for reporting it. 2008-11-10 19:08:37 Bogdan-Andrei Iancu, * [4939] : backport from trunk (rev #4908, #4938): - fixed bug in decrementing the max_forward value: The issue occurs when calling 'mf_process_maxfwd_header' or 'is_maxfwd_lt' script functions more than once within a single script execution The second occurrence always returns as if the max forward header value has reached zero due to an issue with the temporary value (max forwards count) stored by the module being overwritten with zero during an int to string conversion - fixed internal link corruption when 'mf_process_maxfwd_header' is used more than once in the script. Closes bug 2223501. Credits to: Peter Baer (pbaer at galaxytelecom dot net) Tavis Paquette (tavis at galaxytelecom dot net) 2008-11-10 09:14:02 Di-Shi Sun * [4936] : Fixed terminate CDR issue caused by reporting original called number. 2008-11-07 11:10:30 Di-Shi Sun * [4927] : Fixed dest CDR issue for partly corrupted cookie. 2008-11-06 22:09:27 Sergio Gutierrez * [4921] : Backport of trunk revisions 4919, 4916 and 4891 2008-11-06 03:37:33 Di-Shi Sun * [4910] : Fixed issues caused by partly corrupted Record-Route/Route header in BYE. 2008-11-04 21:59:23 Andrei Pisau * [4905] : Fixed memory leaks in seas module. Sync with rev 4904 2008-11-04 17:24:36 Ovidiu Sas * [4903] : backport from trunk (r4902): - fix bogus DBG probe (closes 2220468) - credits to Alex Hermann (axlh) 2008-11-04 14:51:34 Anca Vamanu, * [4901] : - made the presence of expires parameter for Subscription-State header not compulsory as RFC3265 says - fixed bug #2219574 ( submitted by Norm Brandinger ) 2008-11-04 10:40:57 Dan Pascu * [4899] : Fixed incorrect retrun code mentioned in documentation (backported from trunk rev 4898) 2008-11-04 10:09:15 Dan Pascu * [4897] : Fixed issue with returning the profile size in a script variable from get_profile_size (backported from trunk rev 4896) 2008-11-04 09:32:05 Dan Pascu * [4895] : Fixed pvar access to all headers: $(hdr(Name)[*]) (backported from trunk rev 4894) 2008-11-04 09:03:12 Dan Pascu * [4893] : Fixed too many args in macro definition (backported from trunk rev 4892) 2008-11-03 13:52:29 Bogdan-Andrei Iancu, * [4887] : backport from trunk (rev #4886): - fixed bogus test on reply code for dispatcher OPTIONS ping. 408 must be instead of 407. Credits go to Kevin McAllister. Closes patch 2171807. 2008-11-03 12:16:40 Bogdan-Andrei Iancu, * [4885] : backport from trunk (rev #4884): - fixed condition for accouting early media replies (related to fix r4811). Credits go to Alex Boverman 2008-10-31 16:57:29 Anca Vamanu, * [4879] : - fixed bugs descovered at SIPIT - use rls-services document to take the list instead of resource-list document - send 200 OK faster so that retransmissions don't occur because of time consumming processing - added presence_server exported parameter to have the possibility to set the address of the presence server to work when the presence server does not use the default port - fixed wrong double quotes in Content-Type (thanks also to Yoo Chan Jeon for noticing this) - fixed a memory leack for subscribing passing through rls but were for presence server - check first the condition of containing header "Supported: eventlist" so as to avoid additional processing for messages that are not for RLS - fixed Supported header parsing - added log info for each SUBSCRIBE handled by RLS - fixed a bug in timer_notify_update function related to the relevance of expires value(relative instead of absolute) - added deleting record from rls_presentity table when a Notify with subscription-state=terminate is received instead of beeing deleted on timer - added special return code for rls_handle_notify function to show wheter the Notify request was processed or not by RLS 2008-10-31 08:59:56 Di-Shi Sun * [4875] : Changed fr_inv_timer from 30 to 300 to prevent opensips from failing calls too quick. 2008-10-30 11:49:57 Bogdan-Andrei Iancu, * [4867] : backport from trunk (rev #4866): - URIs with @ but no uername part (like sip:@doamin.com) are considered bogus and generate the appropiate error (missing username) Credits go to Andrei Pisau 2008-10-30 10:03:03 Bogdan-Andrei Iancu, * [4865] : backport from trunk (rev #4862): - make the dialog state machine more flexible - allow BYE receivde event in DELETED state; useful for cross BYEs 2008-10-28 14:16:51 Bogdan-Andrei Iancu, * [4846] : backport from trunk (rev #4844, #4834, #4835): - added two new helper functions for searching for non standard headers: get_header_by_name( msg, name, len) get_header_by_static_name( msg, static_name) Second function is actually a macro over the first one - it is useful when the header name is a static string (and uses sizeof to get the len). The new functions are to replace the local implementations form the modules and to fix the following bugs: 1) header names are case insensitive 2) check also len (otherwise hdr ABCDE will match while looking for ABC) 3) do string comp only if hdr type (OTHER) and name len match - more efficient Partial fix for bug #2202134. - small typo fixed in the newly added macro get_header_by_static_name() - for searching non standard headers, use get_header_by_static_name() function Closes bug #2202134. 2008-10-28 12:31:49 Bogdan-Andrei Iancu, * [4842] : backport from trunk (rev #4841): - fixed misspelling in log message Closes patch 2192224. Credits go to Sergio Gutierrez. 2008-10-27 20:16:40 Ovidiu Sas * [4831] : backport from trunk (r4829): - rework the error case for mi_get_profile 2008-10-27 18:09:50 Bogdan-Andrei Iancu, * [4819] : backport from trunk (rev #4818): - more coherent output for the "profile_get_size" MI command Credits go to Ovidiu Sas 2008-10-27 12:02:44 Anca Vamanu, * [4817] : - backport from trunk rev 4815 - fixed bugs discovered at SIPIT - added sending Notify for winfo when a user changes authorization rules( refreshWatchers mi command is received) - changed id source so that it is unique per dialog and not the same for all dialogs a watcher initiates - removed sending Notify for presence on callback for reply for Notify for winfo - problems with this addition that was removed in this commit: - caused multiple Notifies for presence where there were more subscriptions for winfo - might be considered unjust as the server does not respect the expires of the published info and decides that it is not valid when the presentity does not reply to Notify for winfo - changed code in reply for SUbscribe for presence so as to show the status of the subscription( 202 for pending, 200 for the others). - fixed hard coded "presence" event package printed in body for winfo 2008-10-24 11:24:40 Bogdan-Andrei Iancu, * [4814] : backport from trunk (rev #4813): fixed bogus implementation of has_body() function - remove unnecessay parsing of all the message - we are not interested in where a potential body might start -> look only for content-len hdr - remove bogus test and log - get_body() returns a pointer all the time (even if there is no body) 2008-10-24 11:09:18 Bogdan-Andrei Iancu, * [4812] : backport from trunk (rev #4811): - early_media module parameter triggers reply accouting for all provisional replies with body (not only 183). Closes 2167707. 2008-10-22 16:24:37 Anca Vamanu, * [4809] : - fixed outbound proxy when ua is behind nat ( reported by I?\195?\177aki Baz Castillo ) 2008-10-22 14:33:20 Anca Vamanu, * [4807] : - changed function to take RURI so as to take the new one if it is changed in script (reported by Phil Vandry, closes #2173708 ) 2008-10-16 16:33:02 Bogdan-Andrei Iancu, * [4802] : backport from trunk (rev #4800): - fixed the SRV load balancing algorithm. Un updated weight sum was causing access outside the records array Reported Jeff Pyle. 2008-10-13 10:49:56 Bogdan-Andrei Iancu, * [4792] : backport from trunk (rev #4791 ): - fixed len calculation ofr the "norrtpproxy=yes" string - using sizeof(CRLF) is bogus as the null terminater is included - it was replaced with CRLF_LEN Reported by Norman Brandinger Closes bug id #2076632 2008-10-09 13:48:38 Bogdan-Andrei Iancu, * [4784] : backport from trunk (rev #4783): - fixed dialog searching (value based) through the profiles - a dialog may be inserted in the same profile multiple times, but with different values, so iterate thorugh all of them. Credits go to Herman Bastiaens. 2008-10-09 12:24:09 Andrei Pisau * [4782] : - backport from trunk (rev#4781) Added support in the parser to identify the next content-type subtype: media_control+xml [RFC5168] At the section 8 of RFC5168 explains the following: 8. Transport The defined XML document is conveyed using the SIP INFO method [3] with the "Content-Type" set to "application/media_control+xml". This approach benefits from the SIP built-in reliability. Reported by Antonio Abajo. 2008-10-09 10:56:08 Bogdan-Andrei Iancu, * [4780] : backport from trunk (rev #4779) - fixed missing init values for mask and flags in "cr addcarrier" function. Reported by TC. 2008-10-08 18:27:10 Bogdan-Andrei Iancu, * [4778] : backport from trunk (rev #4777): - set the default value of MINSE to 60 if the header exists Reported by Schumann Sebastian . Now is fully tested. 2008-10-08 15:58:16 Bogdan-Andrei Iancu, * [4776] : backport from trunk (rev #4775): - fixed sending replies in SST module - The added header was missing the header terminater (CRLF). Reported by Schumann Sebastian. 2008-10-08 13:20:19 Bogdan-Andrei Iancu, * [4772] : - more docs updates (entitites and email addresses) 2008-10-08 13:05:15 Bogdan-Andrei Iancu, * [4770] : - README files update (following the XML entities changes) 2008-10-08 13:04:05 Bogdan-Andrei Iancu, * [4769] : - updated htnl link entities to correlate with the changes in the doc structuring on the web site 2008-09-30 13:10:19 Bogdan-Andrei Iancu, * [4758] : Backport from trunk (rev #4757): - fixed warning when adding a new domain - the function calls for is_value_in_db were surrounded by quotes. This patch removes the quotes. Closes patch 2129057. Credits go to Norm Brandinger. 2008-09-29 22:16:31 Ovidiu Sas * [4756] : backport from trunk (r4755): - small memory cleanup on exit 2008-09-29 17:38:02 Ovidiu Sas * [4753] : update svn ignore list 2008-09-29 17:36:20 Ovidiu Sas * [4752] : update svn ignore list 2008-09-29 17:33:57 Ovidiu Sas * [4751] : update svn ignore list 2008-09-29 17:30:34 Ovidiu Sas * [4750] : backport from trunk (r4744): - free shared mem on exit 2008-09-23 21:22:00 Dan Pascu * [4747] : Fixed finding the 'Support: eventlist' header (backported from trunk rev 4746) 2008-09-18 00:15:42 Sergio Gutierrez * [4743] : - Corrected grammar in informational messages. - Improved readibility in output of postinstall script. 2008-09-18 00:12:59 Sergio Gutierrez * [4742] : - Removed unused variable from postinstall script. - Corrected grammar in informational messages. 2008-09-18 00:09:26 Sergio Gutierrez * [4741] : - Removed unused variable from postinstall script. - Corrected grammar in informational messages. 2008-09-18 00:07:01 Sergio Gutierrez * [4740] : - Removed unused variable from postinstall scriptr. - Corrected grammar in informational messages. 2008-09-18 00:04:31 Sergio Gutierrez * [4739] : - Removed unused variable in postinstall script. - Corrected grammar of informational messages. 2008-09-17 23:54:13 Sergio Gutierrez * [4738] : - Corrected typos in descriptions. - Removed unused variable in postinstall scrypt. - Corrected grammar in informational messages. 2008-09-16 14:30:08 Anca Vamanu, * [4737] : - backport from trunk rev 4736 - changed filed length for rlsubs_did filed in rls_presentity table ( from 512 to 255) - fixes also key length issues with MySQL 1.4.22 ( reported by Andrew Pogrebennyk ) 2008-09-10 12:18:40 Anca Vamanu, * [4734] : - applied patch item #2102494 from Kobi Eshun - tighten NULL checks during bad event handling 2008-09-09 16:18:01 Anca Vamanu, * [4732] : - backport from trunk - revision 4731 - fixed segmentation fault when db_url was not set and exported functions were used in configuration file ( closes bug item #2091771) 2008-09-05 19:54:09 Sergio Gutierrez * [4730] : Prototype, package info, preinstall and postinstall scripts for Solaris OpenSIPS postgresql support package. 2008-09-05 18:48:03 Sergio Gutierrez * [4729] : Corrected grammar and typos in informational messages and comments. 2008-09-05 17:23:49 Sergio Gutierrez * [4728] : Prototype, package info, preinstall and postinstall script for Solaris SNMP support package, version 1.4.2 2008-09-05 17:21:06 Sergio Gutierrez * [4727] : Prototype and package information for Solaris Perl support package, version 1.4.2 2008-09-05 17:19:32 Sergio Gutierrez * [4726] : Prototype, package info, preinstall and postinstall scripts for OpenSIPS MySQL support package, version 1.4.2 2008-09-05 17:16:20 Sergio Gutierrez * [4725] : Prototype, package info, preinstall and postinstall for Solaris LDAP support package, version 1.4.2 2008-09-05 17:13:18 Sergio Gutierrez * [4724] : Prototype, package info, preinstall and postinstall scripts for OpenSIPS carrierroute support package, version 1.4.2 2008-09-05 17:07:28 Sergio Gutierrez * [4723] : Package info, preinstall and postinstall script for Solaris Berkeley support package, version 1.4.2 2008-09-05 17:05:00 Sergio Gutierrez * [4722] : Prototype for Solaris berkeley support package, version 1.4.2 2008-09-05 17:03:08 Sergio Gutierrez * [4721] : Package information for Solaris base package, version 1.4.2 2008-09-05 17:01:28 Sergio Gutierrez * [4720] : Prototype for Solaris base package, version 1.4.2 2008-09-04 11:23:47 Dan Pascu * [4718] : Fixed function names in documentation (backport from trunk rev 4717) 2008-09-03 17:25:23 Andrei Pisau * [4716] : Fixed error message enconding (backport from trunk rev 4715) 2008-09-03 15:54:35 Dan Pascu * [4714] : Fixed segmentation fault when the To header is missing (backport from trunk rev 4713) 2008-09-01 22:28:01 Bogdan-Andrei Iancu, * [4706] : - version increased to 1.4.2 2008-09-01 22:24:47 Bogdan-Andrei Iancu, * [4705] : backport from trunk (rev #4704): - fixed module linking when libsnmp is compiled from sources. Reported by Richard Revels