[OpenSIPS-Users] CDRTool - Rating Origination and Termination differently

David M. Lee dlee at digium.com
Wed Feb 12 20:57:17 CET 2014


For everyone following along at home:

I’ve updated my CDRTool patch (again) to fix MaxSessionTime and ShowPrice commands, and fix some minor issues that cropped up with DebitBalance.

CDRTool patch - https://gist.github.com/leedm777/8585690

I’ve also discovered that the call_control daemon also needs to be patched to pass through the SIP Application Type from the call_control module onto the CDRTool prepaid engine.

callcontrol patch - https://gist.github.com/leedm777/8926025

I’ll be sending both patches to devel at ag-projects.com. Feedback welcome on both!

-- 
David M. Lee
Digium, Inc. | Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at:  www.digium.com  & www.asterisk.org

On Feb 6, 2014, at 9:29 AM, David M. Lee <dlee at digium.com> wrote:

> I figured that out. I’ve updated the patch on my gist, and updated the rating doc to include a description of how the subtypes work.
> 
> I’m sending the patch to devel at ag-projects.com now.
> 
> Thanks!
> -- 
> David M. Lee
> Digium, Inc. | Software Developer
> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
> Check us out at:  www.digium.com  & www.asterisk.org
> 
> On Jan 28, 2014, at 6:12 AM, Tijmen de Mes <tijmen at ag-projects.com> wrote:
> 
>> Hi,
>> 
>> I run into trouble and reversed the patch. In the rating engine (telnet) DebitBalance function does not return anything anymore with the patch applied, so something goes wrong.
>> 
>> -- 
>> Tijmen de Mes
>> AG-Projects
>> 
>> On 27 januari 2014 at 17:55:01, Tijmen de Mes (tijmen at ag-projects.com) wrote:
>> 
>>> Hi
>>> 
>>> I tested the patch and for now I don’t see any problem with it. Before adding it to trunk, can you update the rating docs and record all changes in 1 patch using darcs? After that I can apply it directly on trunk with your credentials.
>>> 
>>> These instructions to submit the patch also apply on CDRTool:
>>> 
>>> http://sipsimpleclient.org/projects/sipsimpleclient/wiki/SipSupport
>>> 
>>> You don’t need to open a ticket however, just tell me after you send the patch.
>>>  
>>> -- 
>>> Tijmen de Mes
>>> AG-Projects
>>> 
>>> On 26 januari 2014 at 02:08:50, Duane Larson (duane.larson at gmail.com) wrote:
>>> 
>>>> Ugh.... Nevermind.  My "Max Duration" was set to 6 on the Destinations rate setup.  I set it to zero and I think things are looking better now.  Think I'm done for the day.  Good work David!  Really appreciate the patch.
>>>> 
>>>> 
>>>> On Sat, Jan 25, 2014 at 6:56 PM, Duane Larson <duane.larson at gmail.com> wrote:
>>>> Not sure my "price" is being calculated correctly.
>>>> 
>>>> My audio.outbound should be $0.005
>>>> My audio.inbound should be $0.0035
>>>> 
>>>> Here is an example of a call that lasted 2:06 minutes and is audio.outbound
>>>> Increment=6 MinDuration=6 MaxDuration=6 ConnectFee=0.0000 CallId=dc1e32b1ba18ff91a3
>>>> 67aa8df81e8e3c at 0:0:0:0:0:0:0:0 Span=1 Duration=6 DestId=1 default Profile=USA_Default Period=weekend Rate=USA_Default Interval=0-24 Cos
>>>> t=0.0050/60 Price=0.0005 PriceIn=0.0000
>>>> 
>>>> Here is an example of a call that lasted 1:33 minutes and is audio.inbound
>>>> Increment=6 MinDuration=6 MaxDuration=6 ConnectFee=0.0000 CallId=2e0334513a34964e7c0
>>>> a18cd3be449dd at 108.166.97.17:5060 Span=1 Duration=6 DestId=1 default Profile=USA_Default Period=weekend Rate=USA_Default Interval=0-24 C
>>>> ost=0.0035/60 Price=0.0003 PriceIn=0.0000
>>>> 
>>>> Looks like no matter what the duration is for the inbound calls it costs $0.0003 and the outbound calls all cost $0.0005.
>>>> 
>>>> 
>>>> 
>>>> 
>>>> On Sat, Jan 25, 2014 at 6:24 PM, Duane Larson <duane.larson at gmail.com> wrote:
>>>> David/Tijmen/Adrian,
>>>> 
>>>> It is working for me too.  Both inbound and outbound are being recognized and the different rates are being applied.  I will keep looking at it while more calls are being made to make sure there are no unforeseen issues. 
>>>> 
>>>> 
>>>> On Fri, Jan 24, 2014 at 5:35 AM, Tijmen de Mes <tijmen at ag-projects.com> wrote:
>>>> Hi David,
>>>> 
>>>> Thanks for the patch. If have some time Monday I will analyze it and give you some feedback so we include this in CDRTool.
>>>> 
>>>> Besides the rating, I’ve to check if the code that now sets the the ‘route’ for the CDRs and if there are no problems.
>>>> 
>>>>   
>>>> -- 
>>>> Tijmen de Mes
>>>> AG-Projects
>>>> 
>>>> On 23 januari 2014 at 21:21:26, David M. Lee (dlee at digium.com) wrote:
>>>> 
>>>>> I’ve got a first attempt at a patch:
>>>>> https://gist.github.com/leedm777/8585690
>>>>> 
>>>>> To get this to work, your CDR’s will have to record the application
>>>>> subtype. For me, I set $avp(s:call_class) = “audio.inbound” or
>>>>> “audio.outbound” as appropriate in the routes, and added
>>>>> Sip-Application-Type=$avp(s:call_class) to “radius_extra”.
>>>>> 
>>>>> Billing rates will be matched on the full application, allowing
>>>>> different rates depending on the application subtype.
>>>>> 
>>>>> It works with the simple testing I’ve been able to do on my desktop.
>>>>> Feedback, of course, is greatly appreciated.
>>>>> 
>>>>> Duane - Does the patch work for you?
>>>>> 
>>>>> Adrian - Any objections/concerns with this approach?
>>>>> 
>>>>> If it looks good, I’ll work on updating the docs.
>>>>> 
>>>>> Thanks!
>>>>> --
>>>>> David M. Lee
>>>>> Digium, Inc. | Software Developer
>>>>> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
>>>>> Check us out at: www.digium.com & www.asterisk.org
>>>>> 
>>>>> On Jan 23, 2014, at 4:43 AM, Adrian Georgescu <ag at ag-projects.com> wrote:
>>>>> 
>>>>> > I think it would be a good idea.
>>>>> >
>>>>> > Adrian
>>>>> >
>>>>> > On 22 Jan 2014, at 16:58, David Lee (digium) <dlee at digium.com> wrote:
>>>>> >
>>>>> >> Duane Larson wrote:
>>>>> >>> I have been playing with CDRTool for a while but I am not sure if it is
>>>>> >>> possible to rate Origination (Inbound) calls differently than Termination
>>>>> >>> (Outbound) calls from my SIP Provider. For Origination I pay 0.0035 and
>>>>> >>> for Termination I pay 0.005. Keep in mind these costs are for destination
>>>>> >>> "1”.
>>>>> >>
>>>>> >> I've recently run into nearly the same situation.
>>>>> >>
>>>>> >> I tried overloading the Sip-Application-Type field, but it's limited
>>>>> >> by the supportedApplicationTypes array in cdr_generic.php. There also
>>>>> >> seems to be hard coded logic for the different application types.
>>>>> >>
>>>>> >> I think I will patch CDRTool so that you can have subtypes of
>>>>> >> application types (audio.inbound, audio.outbound, etc.). This would
>>>>> >> allow the billing rates to be a bit more specific for these
>>>>> >> situations.
>>>>> >>
>>>>> >> Thoughts?
>>>>> >> --
>>>>> >> David M. Lee
>>>>> >> Digium, Inc. | Software Developer
>>>>> >> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
>>>>> >> Check us out at: www.digium.com & www.asterisk.org
>>>>> >> _______________________________________________
>>>>> >> Users mailing list
>>>>> >> Users at lists.opensips.org
>>>>> >> http://lists.opensips.org/cgi-bin/mailman/listinfo/users
>>>>> >
>>>>> > _______________________________________________
>>>>> > Users mailing list
>>>>> > Users at lists.opensips.org
>>>>> > http://lists.opensips.org/cgi-bin/mailman/listinfo/users
>>>>> 
>>>>> 
>>>>> _______________________________________________
>>>>> Users mailing list
>>>>> Users at lists.opensips.org
>>>>> http://lists.opensips.org/cgi-bin/mailman/listinfo/users
>>>> 
>>>> _______________________________________________
>>>> Users mailing list
>>>> Users at lists.opensips.org
>>>> http://lists.opensips.org/cgi-bin/mailman/listinfo/users
>>>> 
>>>> 
>>>> 
>>>> 
>>>> --
>>>> --
>>>> *--*--*--*--*--*
>>>> Duane
>>>> *--*--*--*--*--*
>>>> --
>>>> 
>>>> 
>>>> 
>>>> --
>>>> --
>>>> *--*--*--*--*--*
>>>> Duane
>>>> *--*--*--*--*--*
>>>> --
>>>> 
>>>> 
>>>> 
>>>> --
>>>> --
>>>> *--*--*--*--*--*
>>>> Duane
>>>> *--*--*--*--*--*
>>>> --
>>>> _______________________________________________
>>>> Users mailing list
>>>> Users at lists.opensips.org
>>>> http://lists.opensips.org/cgi-bin/mailman/listinfo/users
>>> _______________________________________________ 
>>> Users mailing list 
>>> Users at lists.opensips.org 
>>> http://lists.opensips.org/cgi-bin/mailman/listinfo/users 
>> _______________________________________________
>> Users mailing list
>> Users at lists.opensips.org
>> http://lists.opensips.org/cgi-bin/mailman/listinfo/users
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/users/attachments/20140212/becaeafe/attachment.htm>


More information about the Users mailing list